Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi input and cymbal choke #171

Merged
merged 16 commits into from Aug 4, 2014

Conversation

Projects
None yet
2 participants
@blablack
Copy link
Contributor

commented Apr 29, 2014

This patch provides compatibility with edrums cymbal choke through midi aftertouch

  • makes alsa driver compatible with aftertouch
  • makes jack driver compatible with aftertouch
  • handles aftertouch message in midi input and send a note off when necessary
  • note off method can overwrite "ignoring note off" setting when note off sent from aftertouch

@blablack blablack referenced this pull request Apr 30, 2014

Closed

EDrums & Cymbal Choke #151

mauser added a commit that referenced this pull request Aug 4, 2014

@mauser mauser merged commit 15b5808 into hydrogen-music:master Aug 4, 2014

@mauser

This comment has been minimized.

Copy link
Member

commented Aug 4, 2014

Hi!
Thanks again for the patch! I couldn't test the hihat settings yet, but i think i will ask especially for testing with the first alpha/beta release of 0.9.7.

@mauser

This comment has been minimized.

Copy link
Member

commented on 5095411 Aug 5, 2014

@blablack : I've reverted this commit because it caused on my system on some buttons (like the "add pattern" button in the songeditor) the firing of the "click"-event in an inifite loop, so the dialog opened directly again after i closed it.

This comment has been minimized.

Copy link
Member

replied Aug 5, 2014

@blablack : Another thing, but not soo important ;-) Could you use tabs for indentation in your code? I know that there are places in hydrogen were tabs and spaces are mixed, but we would like to try to go for tabs in new code.

@blablack blablack deleted the blablack:cymbal_choke branch Sep 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.