-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change hydrological modelling to classes, add Hydrotel #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour ma part ça semble super et ça implémente les changements comme on a convenu. Toute la partie Hydrotel je laisserai aux experts, mais de ce que je vois je pense qu'on peut merger sans problème.
# Conflicts: # docs/index.rst # environment-dev.yml # environment.yml # pyproject.toml
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RondeauG on peut se prévoir une rencontre lorsque tu seras disponible pour regarder le tout ensemble
# Conflicts: # docs/notebooks/hydrological_modelling.ipynb
# Conflicts: # CHANGES.rst
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
hydrological_modelling
has changed substantially, but was very new.Other information: