Added cryptocurrency examples to README.rst #621
Conversation
Added functionality in rough form as requested in "[Enhancement] Add new daily and IEX methods following the Tiingo API more closely hydrosquall#527" from tiingo-python
Updated with some cryptocurrency examples as requested in hydrosquall#520. I also resolved some capitalization problems in the code, e.g. CLIENT.method rather than client.method as the code example dictates.
Trying to get the formatting correct.
Trying to work out the formatting
Got the formatting in order
Fixing formatting
Bringing Fork Up-To-Date
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 5 5
Lines 255 255
=======================================
Hits 239 239
Misses 16 16 Continue to review full report at Codecov.
|
|
I think that maybe I finally got this correctly merged. Thank you for bearing with me through these struggles. |
There was a problem hiding this comment.
You did it @GenusGeoff, and you caught some unrelated typos in the readme! This is great, thank you for sticking with this. This was the most critical part of #520, as many people depend on the README to figure out how to quickly use a new library, and don't venture into other documentation pages.
The one piece that got accidentally dropped in this process was the line giving you attribution for your contribution (HISTORY.rst) - would you be interested in adding that back in 1 more commit? If not, I'll make a note to add this when I do a future release.
|
|
||
| # Get fundamentals which require daily-updated (like marketCap). A start- | ||
| # and end-date can be passed. If omited, will get all available data. | ||
| fundamentals_daily = CLIENT.get_fundamentals_daily('GOOGL', | ||
| fundamentals_daily = client.get_fundamentals_daily('GOOGL', |
There was a problem hiding this comment.
You can just add it on a later release. That's no problem, at all.
🎉 Hello there 🎉! Thanks for taking the time to contribute to
Tiingo-Python!Summary of Changes
Checklist
HISTORY.rstwith an entry summarizing your change@hydrosquall