Add support for tiingo crypto endpoints to TiingoClient

[n1rna]

🎉 Hello there 🎉! Thanks for taking the time to contribute to Tiingo-Python!

Summary of Changes

• What is the motivation / context for this change?
• Is this a bugfix or a feature?
  This PR adds support for tiingo's crypto endpoints. So I think this will be considered as a feature.
• What does this change / fix? (Link to Github Issue page if applicable)
  This PR solves [Feature] Add support for Tiingo Cryptocurrency Data Endpoint #135

Checklist

• [*] Code follows the style guidelines of this project
• [*] Added tests for new functionality
• [] Update HISTORY.rst with an entry summarizing your change
• Tag a project maintainer

[hydrosquall]

This is a great start @n1rna ! Thank you for taking the time to contribute, I look forward to bringing in your changes to the next release!

[hydrosquall]

These test cases are a great start. Would it be possible to take a pass at writing the test in a way that we add a new fixture to this folder https://github.com/hydrosquall/tiingo-python/tree/master/tests/fixtures? This way, people can see a sample of what the returned data is meant to look like.

Feel free to let me know if you have any questions about how to do this.

[n1rna]

Alright, will add the fixtures ;)

[n1rna]

I have a problem with getting responses from api.tiingo.com! I think my token is rate limited, but other than that, when I make an API call to crypt/top/ price and set a endDate querystring parameter, I get a 500 server error. I don't know it is raising an exception in tiingo's webserver or not.

[tiingo]

Thank you for the great work @n1rna! Please make sure to reach out to me get a free dev account!

You helped us catch an error that was related to older top of book data. We deprecated the "endDate" parameter for top-of-book since nobody seemed to use it and we plan to make order book tick data available shortly. This should help users reconstruct historical top-of-book using the tick data and promote transparency.

[n1rna]

Thanks!
So do I need to remove endDate parameter from the API client and also the test cases in this PR?

[hydrosquall]

This is almost there! Really neat to see how work on this client caught a backend error, thanks for the thorough bug report.

The main suggested change is to deprecate the parameter that was removed as a result of your bug report, the other comments are some optional curiosities I have about the fixtures.yaml.

Additionally, feel free to add yourself to the Authors.rst file if you'd like!

https://github.com/hydrosquall/tiingo-python/blob/master/AUTHORS.rst

Separately, something is up with our CI provider Travis, where the tests are inexplicably not running for your branch, only the LGTM and Snyk checks are running. I'll look into this in a separate issue.

[hydrosquall]

🚀 This is excellent! Thanks for your contribution @n1rna . This will go out in the 0.12.x release.

[sher85]

Hi and thanks for the support with adding crypto endpoints. I could not find an example of the code required to access it on the documentation page, nor when I tried through google. Would you be able to add an example for clarification somewhere?

[hydrosquall]

Hi @sher85 - thanks for reaching out!

There are 3 endpoints available (ignore all the lines with assert in them) - you can see a live example of what arguments go into each function in our test code:

https://github.com/n1rna/tiingo-python/blob/fb1295376a1049b8d2d8819a648b82c9f7c0087b/tests/test_crypto.py#L19-L37

Let me know if you have any questions or what additional information will be helpful - I'll make a note (#520 (comment)) to add a section to the README.md dedicated to usage of the Crypto endpoints, and incorporate your feedback (alternately, would be happy to work together with you to write this section if you're interested in contributing documentation).