Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build status badge #1688

Closed
wants to merge 1 commit into from
Closed

Fix build status badge #1688

wants to merge 1 commit into from

Conversation

mbarkhau
Copy link

I'm not sure why this is currently red, maybe it references the latest build from here: https://travis-ci.org/hylang/hy/builds.

The image url with the explicit branch is probably the better choice.

I'm not sure why this is currently red, maybe it references the latest build from here: https://travis-ci.org/hylang/hy/builds. 
The image url with the explicit branch is probably the better choice.
@Kodiologist
Copy link
Member

Because we're currently running Travis for PRs only, rather than both PRs and pushes, the badge probably won't work in any case. If so, we should just remove it.

@mbarkhau
Copy link
Author

Ahh, I see. So this badge is actually referring to a build that is a few months old?

https://secure.travis-ci.org/hylang/hy.png?branch=master

@Kodiologist
Copy link
Member

I suspect so. But it might also be referring to the last commit that was tested before being pushed (currently https://travis-ci.org/hylang/hy/builds/435140822), which is a reasonable backup. I'm not sure how to tell.

@mbarkhau
Copy link
Author

mbarkhau commented Oct 20, 2018

Maybe this is helpful? https://stackoverflow.com/questions/31882306/how-to-configure-travis-ci-to-build-pull-requests-merges-to-master-w-o-redunda?rq=1

If it were me, and if it's possible, I'd just let it do another build after the merge to master of any pull request.

@Kodiologist
Copy link
Member

The reason I turned off push builds originally was because of a longstanding Travis bug where if you accidentally push a PR branch to origin instead of your own fork, then it gets another redundant build, and if you remove the branch, the new build line sticks around in a permanent failure state. But branches: {only: master} could fix that. It's worth trying.

@Kodiologist
Copy link
Member

The badges in question are gone as of #1811.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants