Use "environment markers" for conditional install_requires #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess at this point it might even make sense to embed this list directly in the |
|
Whoops. It's convenient that there happens to be a straightforward solution to this problem. Yes, |
These are defined in PEP 508: https://www.python.org/dev/peps/pep-0508/#environment-markers The current implementation means that installing 1.0a2 from the published wheel on Python 3.8 does not include `astor` (and thus does not work) because "the Python version that is building the wheel is different from the Python version that is installing it" (from https://hynek.me/articles/conditional-python-dependencies/). I don't think Windows and Linux can share wheels, so `pyreadline` doesn't strictly have to be included here, but it seems more correct to use this method for both.
tianon
force-pushed
the
environment-markers
branch
from
aef3977
to
7b63c71
Compare
|
Oh, I suppose I should add that I've tested this successfully on both Python 3.8 and 3.9 😅 |
Kodiologist
approved these changes
Jul 7, 2021
|
I was worried it would be harder but was pleased to find such a simple fix that I could contribute it myself. 😄 |
scauligi
approved these changes
Jul 9, 2021
|
1.0a3 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are defined in PEP 508: https://www.python.org/dev/peps/pep-0508/#environment-markers
The current implementation means that installing 1.0a2 from the published wheel on Python 3.8 does not include
astor(and thus does not work) because "the Python version that is building the wheel is different from the Python version that is installing it" (from https://hynek.me/articles/conditional-python-dependencies/).I don't think Windows and Linux can share wheels, so
pyreadlinedoesn't strictly have to be included here, but it seems more correct to use this method for both.(Refs 06f34b0 / #1999)