Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Refactors tracing handler to use HttpServerParser #52

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Refactors tracing handler to use HttpServerParser #52

merged 2 commits into from
Dec 15, 2017

Commits on Dec 13, 2017

  1. Refactors tracing handler to use HttpServerParser 

    This commit introduces an implementaton of HttpServerParser and
refactors the server tracing handler such that span name customization
is done via the HttpServerParser instead of directly in the tracing
handler.

In order to make this work, needed to add a wrapper around the standard
Ratpack Response so that things like the PathBinding and original
ServerRequest are available to the HttpServerParser.

Closes #51
    @hyleung
    hyleung committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    ae1a836 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2017

  1. Remove Span start/finish from tracing handler 

    Not needed anymore because Brave's HttpServerHandler takes care of all
this now.
    @hyleung
    hyleung committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    0a79dbb View commit details
    Browse the repository at this point in the history