This repository has been archived by the owner on Jun 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6 by stripping underscores from attributes for the initializer keyword-arguments.
It does it only for the new-style
Attribute
classes because I have the feeling that adding it retroactively to string-based ones would break backward-compatibility big time (I’ll happily listen to contrary opinions :))What this does is basically the following:
I would appreciate both feedback whether this is what you wanted and for a better name for
keep_underscores
because the name is gross. :|