Added pem data

[spacemanspiff2007]

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

• Added tests for changed code.
• Updated documentation for changed code.
  • New functions/classes have to be added to docs/api.rst by hand.
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
    Find the appropriate next version in our __init__.py file.
• Documentation in .rst files is written using semantic newlines.
• Changes (and possible deprecations) are documented in the changelog.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

[spacemanspiff2007]

Closes #73

[hynek]

In addition to the review comments, how would you feel about adding a decoded_payload too? b64decode is part of the stdlib and it seems like most people who want to access the payload in the first place, probably also want to decode it.

[spacemanspiff2007]

how would you feel about adding a decoded_payload too?

Maybe use payload_raw and payload_bytes?
Or rather payload_decoded?

[hynek]

I think payload_decoded is more precise/obvious, yes!

[spacemanspiff2007]

Like this?

[hynek]

yes, LGTM!

I think I'll make it more backwards-compatible and make payload optional with a warning, but we're done here – thanks!

[hynek]

(I understand now why you put it into the breaking section :) – I kinda didn't consider the constructor to be a public API, but 101% someone somewhere is doing just that)

[hynek]

as a heads up: while making is compatible, I've decided the churn isn't worth it and switched to a lazy extraction in 0a9780a, I hope you can live with that.

[spacemanspiff2007]

Yes - of course! Thanks for the heads up