-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pem data #74
Added pem data #74
Conversation
Closes #73 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the review comments, how would you feel about adding a decoded_payload
too? b64decode is part of the stdlib and it seems like most people who want to access the payload in the first place, probably also want to decode it.
Maybe use |
I think |
Like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, LGTM!
I think I'll make it more backwards-compatible and make payload optional with a warning, but we're done here – thanks!
(I understand now why you put it into the breaking section :) – I kinda didn't consider the constructor to be a public API, but 101% someone somewhere is doing just that) |
as a heads up: while making is compatible, I've decided the churn isn't worth it and switched to a lazy extraction in 0a9780a, I hope you can live with that. |
Yes - of course! Thanks for the heads up |
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives.Find the appropriate next version in our
__init__.py
file..rst
files is written using semantic newlines.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!