-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiles with Thickened Edges #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @andrewheumann)
Elements/src/Geometry/Profile.cs
line 146 at r1 (raw file):
public Profile Transformed(Transform transform) { return new Profile(this.Perimeter.TransformedPolygon(transform), this.Voids?.Select(v => v.TransformedPolygon(transform)).ToList() ?? new List<Polygon>(), this._edgeThickness, this.Name);
This method will create a Profile with id = "0000 -00..." I'm not sure if it's ok
Elements/src/Geometry/ThickenedPolyline.cs
line 355 at r1 (raw file):
/// polygonal boundary taking into account those thickness offsets. /// </summary> /// <param name="vertices">An ordered list of vertices representing a closed polygon</param>
polygon . <- at the end of the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @katehryhorenko)
Elements/src/Geometry/Profile.cs
line 146 at r1 (raw file):
Previously, katehryhorenko (Kateryna Hryhorenko) wrote…
This method will create a Profile with id = "0000 -00..." I'm not sure if it's ok
the base class Element
constructor always makes sure the Id is valid. I wrote a throwaway test to confirm that Profile.Transformed
always gives back a profile with a new Id.
Elements/src/Geometry/ThickenedPolyline.cs
line 355 at r1 (raw file):
Previously, katehryhorenko (Kateryna Hryhorenko) wrote…
polygon . <- at the end of the comment
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
BACKGROUND:
ThickenedPolyline
class.DESCRIPTION:
Profile.EdgeThickness
propertyProfile.ThickenedInteriorProfile
Profile.ThickenedExteriorProfile
Profile.ThickenedEdgePolygons
TESTING:
REQUIRED:
CHANGELOG.md
.This change is