Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring before adding multiple representations #1022

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Sep 7, 2023

BACKGROUND:
I'm planning to re-use code that creates Csg.Solid from SolidOperation

DESCRIPTION:
Solid creation is moved to a separate class

TESTING:

  • I tested it on a few functions. I can share them with you.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple typos from the original comments, but otherwise :lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @katehryhorenko)


Elements/src/Utilities/SolidOperationUtils.cs line 32 at r2 (raw file):

            var transform = transformed ? element.Transform : new Transform();

            // Transform the solid operatioon by the the local transform AND the

operatioon => operation (error from the original comment!)


Elements/src/Utilities/SolidOperationUtils.cs line 42 at r2 (raw file):

            }

            // If an addition transform was proovided, don't forget

if an addition => if an additional
proovided => provided.

@katehryhorenko katehryhorenko merged commit f7e32d3 into master Sep 7, 2023
2 checks passed
@katehryhorenko katehryhorenko deleted the multiple-representations branch September 7, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants