GltfExtensions: mesh creation refactoring #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheumann
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
LGTM! Maybe we can also eventually get rid of AddTriangleMesh too, but not necessary for now.
Reviewable status:
complete! 1 of 1 approvals obtained
andrewheumann
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
katehryhorenko
commented
Sep 14, 2023
There was a problem hiding this comment.
Oh yes, I'm planning to delete it! But not today :)
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
Small refactoring before adding serialization of multiple representations to glb
DESCRIPTION:
Added more general method AddMesh that is reused inside AddTriangularMesh and AddPointsOrLines
TESTING:
This change is