Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gltf: parent node for an element and the representations as children #1038

Merged
merged 3 commits into from
Oct 10, 2023
Merged

gltf: parent node for an element and the representations as children #1038

merged 3 commits into from
Oct 10, 2023

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Oct 10, 2023 •
edited by andrewheumann

BACKGROUND:

  • When I added multiple representation part of the functionality was broken because we are assuming in Explore that the first 3D object is a parent object and it's the element geometry. But with multiple representations it can be one of the representations

DESCRIPTION:
-This PR changes the gltf serialization for multiple representations, The representation instance becomes the child node of the element node. Element node contains Transform.

TESTING:
image

GlbElementNode

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

andrewheumann
andrewheumann approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

andrewheumann
andrewheumann approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@katehryhorenko katehryhorenko merged commit 9f8db4e into master Oct 10, 2023
2 checks passed
@katehryhorenko katehryhorenko deleted the multiple-representations-two branch October 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheumann andrewheumann andrewheumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katehryhorenko @andrewheumann