Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bbox validator #917

Merged
merged 2 commits into from
Nov 8, 2022
Merged

remove bbox validator #917

merged 2 commits into from
Nov 8, 2022

Conversation

wynged
Copy link
Member

@wynged wynged commented Nov 7, 2022 •
edited by andrewheumann

BACKGROUND:

  • A developer had a really tricky bug in a function because of a model failing to deserialize. They eventually traced it down to a failure creating a BBox3. The failure was only because our validator doesn't allow degenerate bounding boxes. There's no real reason to disallow 0 volume bounding boxes.

DESCRIPTION:

  • Remove the BBox3 validator

TESTING:

  • Tests are fine.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

andrewheumann
andrewheumann approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit d89ba8e into master Nov 8, 2022
@wynged wynged deleted the remove-bbox-validator branch November 8, 2022 14:15
@DmytroMuravskyi DmytroMuravskyi mentioned this pull request Jan 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheumann andrewheumann andrewheumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wynged @andrewheumann