Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GetCells caching #931

Merged
merged 2 commits into from
Dec 14, 2022
Merged

fix GetCells caching #931

merged 2 commits into from
Dec 14, 2022

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Dec 14, 2022 •
edited

BACKGROUND:

  • in Grid2d, calling GetCells would cause Cells to be cached, and changes to child grids like SplitAtOffset would not correctly invalidate the cached result.

DESCRIPTION:

  • Ensures that all child grid changes invalidate the parent grid2d's computed cells.

TESTING:

  • Added a minimal test, and also ran (but did not commit) the example from @serenayl's code.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

serenayl
serenayl approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@serenayl serenayl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit 264d70c into master Dec 14, 2022
@andrewheumann andrewheumann deleted the fix-get-cells branch December 14, 2022 16:55
@serenayl serenayl restored the fix-get-cells branch January 4, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenayl serenayl serenayl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewheumann @serenayl