Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mesh merge exception #936

Merged
merged 1 commit into from
Dec 29, 2022
Merged

fix mesh merge exception #936

merged 1 commit into from
Dec 29, 2022

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Dec 29, 2022

BACKGROUND:

  • Adding the first vertex to a mesh with "merge" on would throw an exception.

DESCRIPTION:

  • Fixes the exception.

TESTING:
-Added a new test which failed and now passes.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @andrewheumann)


Elements/src/Geometry/Mesh.cs line 351 at r1 (raw file):

            {
                // if we've never added any vertices, we may not have a valid bbox, so we have to guess at a default size.
                var bbox = _bbox.IsValid() ? _bbox : new BBox3((-10, -10, -10), (10, 10, 10));

that's a big default box, but approved!

@andrewheumann andrewheumann merged commit 9e4b80f into master Dec 29, 2022
@andrewheumann andrewheumann deleted the mesh-merge-bug branch December 29, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants