Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Flipped parameter to ReverseWinding #952

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Mar 22, 2023

BACKGROUND:

  • There was a concern that Flipped was ambiguous

DESCRIPTION:

  • rename extrude Flipped to ReverseWinding

This change is Reviewable

Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit db61f01 into master Mar 22, 2023
@andrewheumann andrewheumann deleted the rename-flipped-parameter branch March 22, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants