Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken model text #955

Merged
merged 6 commits into from
Apr 16, 2023
Merged

Fix broken model text #955

merged 6 commits into from
Apr 16, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Mar 30, 2023 •
edited

BACKGROUND:

  • James Bradley noticed that some model text was getting screwed up.
  • It was due to corrupting of the texture atlas on re-load at GLTF creation time, due to a bug in ImageSharp.

DESCRIPTION:

  • Upgrades ImageSharp

TESTING:

  • I ran the existing ModelText tests, and visually verified that it looked correct. It seems some of the settings we had to supply previously (left/top alignment, etc) are no longer needed.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

ikeough
ikeough reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@ikeough ikeough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: 0 of 1 approvals obtained

@ikeough ikeough mentioned this pull request Apr 14, 2023
Closed
ikeough
ikeough approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@ikeough ikeough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ikeough ikeough modified the milestones: 1.5, 2.0 Apr 15, 2023
@ikeough
Copy link
Contributor

ikeough commented Apr 15, 2023

I fixed the merge conflict, but it seems like there are some test failures related to bad PNG headers. I'm moving this into 2.0.

@andrewheumann andrewheumann merged commit f14ef8e into master Apr 16, 2023
1 check passed
@andrewheumann andrewheumann deleted the fix-broken-modeltext branch April 16, 2023 22:48
@jamesbradleym jamesbradleym linked an issue May 18, 2023 that may be closed by this pull request
ModelText broken when passing a list of text objects #981
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeough ikeough ikeough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

ModelText broken when passing a list of text objects
2 participants
@andrewheumann @ikeough