Bug fix Polygon.Contains3D #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there's one failing test. Do you have any interest in attempting to fix? |
|
I’m off the grid for almost a month, so it would be great if you guys could take a look 😊 Otherwise I’ll revisit this later on |
pederlh
force-pushed
the
fix-Contains-bug
branch
2 times, most recently
from
51cace4
to
237c44f
Compare
|
The |
|
Thanks for the nudge @pederlh, all tests are passing now, so I'm going to go ahead and merge. Sorry feedback on this PR took so long, and thanks for your contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
Fixed a bug causing issues in own code.
DESCRIPTION:
The
out Containment containmentparameter in Polygon.Contains3D isn't updated if one of the other polygon's vertices is outside this polygon. In that caseContainment.Insidewould be passed instead ofContainment.Outside.TESTING:
None.
FUTURE WORK:
None.
REQUIRED:
CHANGELOG.md.COMMENTS:
This change is