Missing spaces: Implemented traverse algorithm that is based on edges rather than nodes #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test to check if FindAllClosedRegions basic functionality works correctly.
Added a test - a room with two inner leaves. FindAllClosedRegions will find only a single clockwise region. Such regions are filtered out during the rooms search, so such room will be missed.
- Switched to traversing through edges during closed regions search. - Fixed TwoLeavesClosedRegions test. - Fixed several other tests that extracted an additional clockwise cycle. - EShapeNetworkClosedRegions test is broken, but it will be fixed later.
No logic changes
- Filtered out "closed regions" that were created from path by edges backtracking. - EShapeNetworkClosedRegions test is fixed by these changes.
Removed codirectional edges from adjacency matrix. Sometimes several edges with the same start have the same direction. In such cases the shortest edge stays, and other edges are replaced with smaller edges between consecutive points. For example: A ----- B ----- C ----- D There are edges AB, AC, AD. They will be replaced with AB, BC and CD.
andrewheumann
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
andrewheumann
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Looks great! thanks for taking on this work, sorry it took me a while to review!
Reviewable status:
katehryhorenko
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
katehryhorenko
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
I tested this changes on Drywall function. Everything works great
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
DESCRIPTION:
TESTING:
FUTURE WORK:
This change is