Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't permit arcs to have decreasing angle domains #999

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Jul 26, 2023

BACKGROUND:

DESCRIPTION:

  • Updates Arc constructors to ensure that EndAngle is always greater than StartAngle.

TESTING:

  • I added a test for every modified constructor, to verify that for any pair of angles A,B, arc(A,B) looked just like arc(B,A), but parameterized in the opposite direction.
  • I added a test to construct an IndexedPolycurve containing an arc which runs "clockwise" with respect to its circle / the Z axis, to ensure consistency in direction of the overall polycurve:
    image
  • I added a test for issue Arc.Polyline doesn't work if its domain has negative length. #994's original complaint, and visually verified that it worked.
  • All tests pass.

FUTURE WORK:

  • We may need to introduce a notion of SenseAgreement as STEP does for more complex curves, such that a subcurve could act like it was running in the opposite direction from its basis curve. Or maybe not ¯\_(ツ)_/¯

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@andrewheumann andrewheumann merged commit 37a9697 into master Jul 26, 2023
2 checks passed
@andrewheumann andrewheumann deleted the arc-consistency branch July 26, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants