Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close crashes if server is not running #4

Closed
briansorahan opened this issue Feb 3, 2015 · 1 comment
Closed

Close crashes if server is not running #4

briansorahan opened this issue Feb 3, 2015 · 1 comment
Labels

Comments

@briansorahan
Copy link
Contributor

Found this due to stupid behavior on my part, but thought it might be good to be more defensive in the OscServer.Close method. Here is the code that reproduces:

package main

import (
    "github.com/hypebeast/go-osc/osc"
)

func main() {
    server := osc.NewOscServer("127.0.0.1", 23898)
    server.Close()
}
@hypebeast
Copy link
Owner

This issue is fixed with #5

@hypebeast hypebeast added the bug label Feb 3, 2015
daveyarwood added a commit to daveyarwood/go-osc that referenced this issue Jan 12, 2020
example output:

-- OSC Bundle (2020-01-12 08:42:13.430108205 -0500 EST):
  -- OSC Message hypebeast#1: /bundle/message/1 ,Tsb true test string 956 blob
  -- OSC Message hypebeast#2: /bundle/message/3 ,Ni Nil 70030
  -- OSC Bundle (2020-01-12 08:42:13.430141439 -0500 EST):
    -- OSC Message hypebeast#1: /bundle/message/2 ,s test string 353
    -- OSC Message hypebeast#2: /bundle/message/3 ,iTb 24665 true blob
    -- OSC Bundle (2020-01-12 08:42:13.430142487 -0500 EST):
      -- OSC Message hypebeast#1: /bundle/message/2 ,FN false Nil
      -- OSC Bundle (2020-01-12 08:42:13.430143456 -0500 EST):
        -- OSC Bundle (2020-01-12 08:42:13.430144334 -0500 EST):
          -- OSC Message hypebeast#1: /bundle/message/1 ,si test string 370 18937
          -- OSC Message hypebeast#2: /bundle/message/2 ,Ts true test string 275
          -- OSC Bundle (2020-01-12 08:42:13.430158528 -0500 EST):
            -- OSC Message hypebeast#1: /bundle/message/1 ,TiT true 11536 true
            -- OSC Bundle (2020-01-12 08:42:13.430168011 -0500 EST):
              -- OSC Message hypebeast#1: /bundle/message/1 ,iF 53026 false
              -- OSC Message hypebeast#2: /bundle/message/2 ,bi blob 91772
              -- OSC Message hypebeast#3: /bundle/message/3 ,N Nil
              -- OSC Message hypebeast#4: /bundle/message/4 ,T true
daveyarwood added a commit to daveyarwood/go-osc that referenced this issue Jan 13, 2020
example output:

-- OSC Bundle (2020-01-12 08:42:13.430108205 -0500 EST):
  -- OSC Message hypebeast#1: /bundle/message/1 ,Tsb true test string 956 blob
  -- OSC Message hypebeast#2: /bundle/message/3 ,Ni Nil 70030
  -- OSC Bundle (2020-01-12 08:42:13.430141439 -0500 EST):
    -- OSC Message hypebeast#1: /bundle/message/2 ,s test string 353
    -- OSC Message hypebeast#2: /bundle/message/3 ,iTb 24665 true blob
    -- OSC Bundle (2020-01-12 08:42:13.430142487 -0500 EST):
      -- OSC Message hypebeast#1: /bundle/message/2 ,FN false Nil
      -- OSC Bundle (2020-01-12 08:42:13.430143456 -0500 EST):
        -- OSC Bundle (2020-01-12 08:42:13.430144334 -0500 EST):
          -- OSC Message hypebeast#1: /bundle/message/1 ,si test string 370 18937
          -- OSC Message hypebeast#2: /bundle/message/2 ,Ts true test string 275
          -- OSC Bundle (2020-01-12 08:42:13.430158528 -0500 EST):
            -- OSC Message hypebeast#1: /bundle/message/1 ,TiT true 11536 true
            -- OSC Bundle (2020-01-12 08:42:13.430168011 -0500 EST):
              -- OSC Message hypebeast#1: /bundle/message/1 ,iF 53026 false
              -- OSC Message hypebeast#2: /bundle/message/2 ,bi blob 91772
              -- OSC Message hypebeast#3: /bundle/message/3 ,N Nil
              -- OSC Message hypebeast#4: /bundle/message/4 ,T true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants