fix pointer reference error to interface #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a complete newbie in Go , I´m assuming this as a fix, I´ve remove the pointer reference to OscPacket in Send method, and it seems to work
|
Hi Miguel, Thanks for your comments and fix. The problem is that OscPacket is an interface and an interface in Go can't have a pointer, because an interface is already a pointer. I just pushed an update for go-osc to Github. This update also includes an OSC server implementation. The update should be a lot more 'stable' than the old code on Github. It's still not a stable release, but i'm working on it and i hope i can release a stable and feature complete version in the next time. If you want, check out the new code and let me know what you thing ;) |
|
@hypebeast, that was fast! I'will look forward for updates on this package Regards |
daveyarwood
added a commit
to daveyarwood/go-osc
that referenced
this pull request
Jan 12, 2020
example output: -- OSC Bundle (2020-01-12 08:42:13.430108205 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,Tsb true test string 956 blob -- OSC Message hypebeast#2: /bundle/message/3 ,Ni Nil 70030 -- OSC Bundle (2020-01-12 08:42:13.430141439 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/2 ,s test string 353 -- OSC Message hypebeast#2: /bundle/message/3 ,iTb 24665 true blob -- OSC Bundle (2020-01-12 08:42:13.430142487 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/2 ,FN false Nil -- OSC Bundle (2020-01-12 08:42:13.430143456 -0500 EST): -- OSC Bundle (2020-01-12 08:42:13.430144334 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,si test string 370 18937 -- OSC Message hypebeast#2: /bundle/message/2 ,Ts true test string 275 -- OSC Bundle (2020-01-12 08:42:13.430158528 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,TiT true 11536 true -- OSC Bundle (2020-01-12 08:42:13.430168011 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,iF 53026 false -- OSC Message hypebeast#2: /bundle/message/2 ,bi blob 91772 -- OSC Message hypebeast#3: /bundle/message/3 ,N Nil -- OSC Message hypebeast#4: /bundle/message/4 ,T true
daveyarwood
added a commit
to daveyarwood/go-osc
that referenced
this pull request
Jan 13, 2020
example output: -- OSC Bundle (2020-01-12 08:42:13.430108205 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,Tsb true test string 956 blob -- OSC Message hypebeast#2: /bundle/message/3 ,Ni Nil 70030 -- OSC Bundle (2020-01-12 08:42:13.430141439 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/2 ,s test string 353 -- OSC Message hypebeast#2: /bundle/message/3 ,iTb 24665 true blob -- OSC Bundle (2020-01-12 08:42:13.430142487 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/2 ,FN false Nil -- OSC Bundle (2020-01-12 08:42:13.430143456 -0500 EST): -- OSC Bundle (2020-01-12 08:42:13.430144334 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,si test string 370 18937 -- OSC Message hypebeast#2: /bundle/message/2 ,Ts true test string 275 -- OSC Bundle (2020-01-12 08:42:13.430158528 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,TiT true 11536 true -- OSC Bundle (2020-01-12 08:42:13.430168011 -0500 EST): -- OSC Message hypebeast#1: /bundle/message/1 ,iF 53026 false -- OSC Message hypebeast#2: /bundle/message/2 ,bi blob 91772 -- OSC Message hypebeast#3: /bundle/message/3 ,N Nil -- OSC Message hypebeast#4: /bundle/message/4 ,T true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a complete newbie in Go , I´m assuming this as a fix, I´ve remove the pointer reference to OscPacket in Send method, and it seems to work