Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override index.html #13

Closed
wants to merge 1 commit into from
Closed

Conversation

timhaywood
Copy link
Collaborator

Return additional tags rather than a modified html template.

Based on the Vite docs here: https://vitejs.dev/guide/api-plugin.html#transformindexhtml

Also deleted the now unused template file.

fixes #12

return additional tags rather than a modified html template

fixes hyperbrew#12
@justintaylor-dev
Copy link
Contributor

@timhaywood thanks for getting a start on this!

There are some other items that need to be in place on order for dev and build to work both inside CEP and in the browser.

Branched off and will merge here: #14

@timhaywood
Copy link
Collaborator Author

Thanks so much! Will check out your changes, the CEP world is still mostly a mystery for me :)

Appreciate your fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.html is replaced with template contents on build
2 participants