feat: Use Popover instead of Tooltip for line chart overflow

hyperdxio · Jan 4, 2024 · ac44684 · ac44684
1 parent 619bd1a
commit ac44684
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 14 deletions.
diff --git a/packages/app/src/HDXLineChart.tsx b/packages/app/src/HDXLineChart.tsx
@@ -3,6 +3,7 @@ import Link from 'next/link';
 import cx from 'classnames';
 import { add, format } from 'date-fns';
 import pick from 'lodash/pick';
+import { toast } from 'react-toastify';
 import {
   Bar,
   BarChart,
@@ -17,7 +18,7 @@ import {
   XAxis,
   YAxis,
 } from 'recharts';
-import { Tooltip as MTooltip } from '@mantine/core';
+import { Popover } from '@mantine/core';
 
 import api from './api';
 import { convertGranularityToSeconds, Granularity } from './ChartUtils';
@@ -30,6 +31,24 @@ import styles from '../styles/HDXLineChart.module.scss';
 
 const MAX_LEGEND_ITEMS = 4;
 
+function CopyableLegendItem({ entry }: any) {
+  return (
+    <span
+      className={styles.legendItem}
+      style={{ color: entry.color }}
+      role="button"
+      onClick={() => {
+        window.navigator.clipboard.writeText(entry.value);
+        toast.success(`Copied to clipboard`);
+      }}
+      title="Click to expand"
+    >
+      <i className="bi bi-circle-fill me-1" style={{ fontSize: 6 }} />
+      {entry.value}
+    </span>
+  );
+}
+
 function ExpandableLegendItem({ entry, expanded }: any) {
   const [_expanded, setExpanded] = useState(false);
   const isExpanded = _expanded || expanded;
@@ -68,27 +87,24 @@ export const LegendRenderer = memo<{
         />
       ))}
       {restItems.length ? (
-        <MTooltip
-          color="gray"
-          withinPortal
-          withArrow
-          label={
+        <Popover withinPortal withArrow closeOnEscape closeOnClickOutside>
+          <Popover.Target>
+            <div className={cx(styles.legendItem, styles.legendMoreLink)}>
+              +{restItems.length} more
+            </div>
+          </Popover.Target>
+          <Popover.Dropdown p="xs">
             <div className={styles.legendTooltipContent}>
               {restItems.map((entry, index) => (
-                <ExpandableLegendItem
+                <CopyableLegendItem
                   key={`item-${index}`}
                   value={entry.value}
                   entry={entry}
-                  expanded
                 />
               ))}
             </div>
-          }
-        >
-          <div className={cx(styles.legendItem, styles.legendMoreLink)}>
-            +{restItems.length} more
-          </div>
-        </MTooltip>
+          </Popover.Dropdown>
+        </Popover>
       ) : null}
     </div>
   );

diff --git a/packages/app/styles/HDXLineChart.module.scss b/packages/app/styles/HDXLineChart.module.scss
@@ -15,6 +15,10 @@
   word-break: break-all;
   word-wrap: break-word;
   line-height: 1.2;
+
+  &:active {
+    opacity: 0.5;
+  }
 }
 
 .legendMoreLink {