Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Side Panel: exceptions ui improvements #118

Merged
merged 2 commits into from Nov 22, 2023

Conversation

svc-shorpo
Copy link
Contributor

  • Show Trace tab for exceptions by default
  • Add fetch and navigation info to breadcrumb columns

Screenshot 2023-11-20 at 7 14 42 PM

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: b8d5d76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!! 🔥 A few other improvements when trying this out:

  • would be nice to get XHR and http events
  • I still think it'd be nice if the console log level was next to the category, so it's clear a message is console.error vs a console.log
  • I think it'd be nice if the stack trace and breadcrumbs had a semi-collapsed state and can be expanded to more details, just to avoid scrolling a ton on long stack traces

@svc-shorpo
Copy link
Contributor Author

ooo great suggestions, def there's a lot to improve still. i'll do it in a separate PR

@svc-shorpo svc-shorpo merged commit abe3b12 into hyperdxio:main Nov 22, 2023
3 checks passed
@svc-shorpo svc-shorpo deleted the HDX-171 branch November 22, 2023 00:26
@svc-shorpo
Copy link
Contributor Author

@MikeShi42 made improvements here #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants