Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry exceptions ui improvements #122

Merged
merged 3 commits into from Nov 25, 2023
Merged

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Nov 22, 2023

Sentry exceptions ui improvements

  • Show data for XHR (method, status, url)
  • Show http status and console.log level in the category column for better visibility
  • Show only 5 most recent frames and breadcrumbs with a button to show all rows
  • Better text truncating

Screenshot 2023-11-21 at 9 44 02 PM

Screenshot 2023-11-21 at 9 44 18 PM

Screen.Recording.2023-11-21.at.9.49.42.PM.mov

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 28309c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MikeShi42
MikeShi42 previously approved these changes Nov 22, 2023
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeessssssss (though i'm assuming this will be rebased on the sb branch)

onClick={(v: any) => setTab(v)}
onClick={(v: any) => {
setTab(v);
throw new Error('For Kolechia');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to clean this one up 😄

@@ -756,3 +756,7 @@ div.react-datepicker {
opacity: 0.7;
}
}

.no-underline {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use text-decoration-none from bs

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢🚢

@svc-shorpo svc-shorpo merged commit ddd4867 into main Nov 25, 2023
3 checks passed
@svc-shorpo svc-shorpo deleted the sr/sentry-improvements-2 branch November 25, 2023 00:53
kodiakhq bot pushed a commit that referenced this pull request Nov 28, 2023
in this branch:
93657ac2b1220ffbc8898d5d432fffdfb9adea74543fce0bf318dddd93bfd9d5  yarn.lock

before #122:
93657ac2b1220ffbc8898d5d432fffdfb9adea74543fce0bf318dddd93bfd9d5  yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants