Fixing returning NaN when rate metrics change / reset counter #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c19271 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
reviewed
Nov 27, 2023
| @@ -1,4 +1,5 @@ | |||
| import * as clickhouse from '..'; | |||
| import { describe, beforeEach, jest, it, expect } from '@jest/globals'; | |||
There was a problem hiding this comment.
I don't think we need to import these from globals. did you hit any issues on local ?
wrn14897
reviewed
Nov 27, 2023
packages/api/src/clickhouse/index.ts
Outdated
| @@ -704,6 +704,7 @@ export const getMetricsChart = async ({ | |||
| startTime: number; // unix in ms | |||
| teamId: string; | |||
| }) => { | |||
| await redisClient.connect(); | |||
There was a problem hiding this comment.
no need for this. redis client should be connected when server starts
MikeShi42
reviewed
Nov 28, 2023
| @@ -42,4 +43,29 @@ describe('clickhouse', () => { | |||
| expect(clickhouse.client.insert).toHaveBeenCalledTimes(2); | |||
| expect.assertions(2); | |||
| }); | |||
|
|
|||
| it('getMetricsChart', async () => { | |||
There was a problem hiding this comment.
would be awesome to have a bit more descriptive of a test case name
wrn14897
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #120
Intended to handle the case where a nonsensical rate would be returned (e.g. massively negative) or the metric
_string_attributeschange mid-query, to either clamp to zero or filter out possible NaN being currently returned. This should create cleaner graphs for rate metrics, allowing the rate to interpolate over missing data instead of creating a gap in the graph