Fixing returning NaN when rate metrics change / reset counter

.changeset/silent-keys-prove.md

@@ -0,0 +1,5 @@
+---
+'@hyperdx/api': patch
+---
+
+Filter out NaN values from metric charts

Makefile

@@ -25,7 +25,7 @@ dev-down:
 
 .PHONY: dev-lint
 dev-lint:
-	./docker/ingestor/run_linting.sh && npx nx run-many -t lint
+	./docker/ingestor/run_linting.sh && npx nx run-many -t lint:fix
 
 .PHONY: ci-lint
 ci-lint:

packages/api/package.json

@@ -89,6 +89,7 @@
     "dev:task": "ts-node -r tsconfig-paths/register -r '@hyperdx/node-opentelemetry/build/src/tracing' ./src/tasks/index.ts",
     "build": "rimraf ./build && tsc && tsc-alias",
     "lint": "eslint . --ext .ts",
+    "lint:fix": "eslint . --ext .ts --fix",
     "ci:lint": "yarn lint && yarn tsc --noEmit",
     "ci:int": "jest --runInBand --ci --forceExit --coverage",
     "dev:int": "jest --watchAll --runInBand --detectOpenHandles",

packages/api/src/clickhouse/__tests__/clickhouse.test.ts

@@ -1,6 +1,18 @@
 import * as clickhouse from '..';
+import { closeDB, getServer } from '@/fixtures';
 
 describe('clickhouse', () => {
+  const server = getServer();
+
+  beforeAll(async () => {
+    await server.start();
+  });
+
+  afterAll(async () => {
+    await server.closeHttpServer();
+    await closeDB();
+  });
+
   beforeEach(() => {
     jest.clearAllMocks();
   });
@@ -42,4 +54,29 @@ describe('clickhouse', () => {
     expect(clickhouse.client.insert).toHaveBeenCalledTimes(2);
     expect.assertions(2);
   });
+
+  it('getMetricsChart avoids sending NaN to frontend', async () => {
+    jest
+      .spyOn(clickhouse.client, 'query')
+      .mockResolvedValueOnce({ json: () => Promise.resolve({}) } as any);
+
+    await clickhouse.getMetricsChart({
+      aggFn: clickhouse.AggFn.AvgRate,
+      dataType: clickhouse.MetricsDataType.Sum,
+      endTime: Date.now(),
+      granularity: clickhouse.Granularity.OneHour,
+      name: 'test',
+      q: '',
+      startTime: Date.now() - 1000 * 60 * 60 * 24,
+      teamId: 'test',
+    });
+
+    expect(clickhouse.client.query).toHaveBeenCalledTimes(2);
+    expect(clickhouse.client.query).toHaveBeenCalledWith(
+      expect.objectContaining({
+        format: 'JSON',
+        query: expect.stringContaining('isNaN(rate) = 0'),
+      }),
+    );
+  });
 });

packages/api/src/clickhouse/index.ts

@@ -190,9 +190,6 @@ export const buildLogStreamAdditionalFilters = (
 export const healthCheck = () => client.ping();
 
 export const connect = async () => {
-  if (config.IS_CI) {
-    return;
-  }
   // FIXME: this is a hack to avoid CI failure
   logger.info('Checking connections to ClickHouse...');
   // health check
@@ -814,6 +811,8 @@ FROM
   (
     ?
   )
+WHERE
+  isNaN(rate) = 0
 `.trim(),
     [SqlString.raw(sumMetricSource)],
   );

packages/app/package.json

@@ -11,6 +11,7 @@
     "build": "next build",
     "start": "next start",
     "lint": "eslint . --ext .ts,.tsx",
+    "lint:fix": "eslint . --ext .ts,.tsx --fix",
     "ci:lint": "yarn lint && yarn tsc --noEmit",
     "ci:unit": "jest --ci --coverage"
   },