Service Dashboard Endpoint Sidepanel #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MikeShi42
commented
Jan 6, 2024
MikeShi42
commented
|
jaggederest
reviewed
Jan 6, 2024
MikeShi42
force-pushed
the
mikeshi/service-endpoint-sidepanel
branch
from
2bb8b57
to
63ad5a8
Compare
wrn14897
reviewed
Jan 7, 2024
packages/api/src/clickhouse/index.ts
Outdated
Comment on lines
1541
to
1548
| const parentSpanWhereCondition = await buildSearchQueryWhereCondition({ | ||
| endTime, | ||
| propertyTypeMappingsModel, | ||
| query: parentSpanWhere, | ||
| startTime, | ||
| }); | ||
|
|
||
| const childrenSpanWhereCondition = await buildSearchQueryWhereCondition({ |
There was a problem hiding this comment.
nit: can do this concurrently ?
wrn14897
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.