Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Node page #252

Merged
merged 3 commits into from Jan 19, 2024
Merged

feat: Node page #252

merged 3 commits into from Jan 19, 2024

Conversation

svc-shorpo
Copy link
Contributor

Screenshot 2024-01-18 at 9 55 35 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024 •
edited

⚠️ No Changeset found

Latest commit: 91525dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-shorpo svc-shorpo force-pushed the sr/nodes branch 2 times, most recently from e03f15e to f55985c Compare January 19, 2024 05:21
MikeShi42
MikeShi42 reviewed Jan 19, 2024
View reviewed changes
packages/app/src/utils.tsx
} else if (seconds < 60 * 60 * 24) {
return `${Math.floor(seconds / 60 / 60)}h`;
} else {
return `${Math.floor(seconds / 60 / 60 / 24)}d`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would https://date-fns.org/v3.2.0/docs/formatDistance or formatDistanceToNowStrictShort (in the utils) not work here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm formatDistance could work, but don't like its verbose output format. formatDistanceToNowStrictShort worked, but I ran into weird bug with seconds being added between re-renders

@kodiakhq kodiakhq bot merged commit be0c12d into main Jan 19, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the sr/nodes branch January 19, 2024 05:55
@svc-shorpo svc-shorpo mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svc-shorpo @MikeShi42