Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Node Details Panel #260

Merged
merged 2 commits into from
Jan 21, 2024
Merged

feat: Node Details Panel #260

merged 2 commits into from
Jan 21, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Jan 21, 2024

lmk if we want to add/change anything

Screenshot 2024-01-20 at 10 15 23 PM

Copy link

changeset-bot bot commented Jan 21, 2024

⚠️ No Changeset found

Latest commit: a302e9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

</td>
<td>{node.uptime ? formatUptime(node.uptime) : '–'}</td>
</tr>
<Link key={node.name} href={getLink(node.name)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we can add anchor tags to these so they're more clicky?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very trivial, let's descope for now :D

</Card>
</Grid.Col>
<Grid.Col span={12}>
<InfraPodsStatusTable dateRange={dateRange} where={where} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking on the pod table here, the side panel gets obscured behind since it's triggering it in the "wrong" z index context. I wonder if we still need to import side panels like we do with the log side panel (along with the table, instead of just globally on a page).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a hack to check if the panel is nested, but going to rework it with a separate state later

table: 'metrics',
field: 'k8s.node.condition_ready - Gauge',
type: 'table',
aggFn: 'avg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want last_value for both of these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@svc-shorpo svc-shorpo merged commit f265739 into main Jan 21, 2024
4 checks passed
@svc-shorpo svc-shorpo deleted the sr/node-panle branch January 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants