-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node Details Panel #260
Conversation
|
</td> | ||
<td>{node.uptime ? formatUptime(node.uptime) : '–'}</td> | ||
</tr> | ||
<Link key={node.name} href={getLink(node.name)}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance we can add anchor tags to these so they're more clicky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not very trivial, let's descope for now :D
</Card> | ||
</Grid.Col> | ||
<Grid.Col span={12}> | ||
<InfraPodsStatusTable dateRange={dateRange} where={where} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When clicking on the pod table here, the side panel gets obscured behind since it's triggering it in the "wrong" z index context. I wonder if we still need to import side panels like we do with the log side panel (along with the table, instead of just globally on a page).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added a hack to check if the panel is nested, but going to rework it with a separate state later
table: 'metrics', | ||
field: 'k8s.node.condition_ready - Gauge', | ||
type: 'table', | ||
aggFn: 'avg', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want last_value
for both of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
lmk if we want to add/change anything