Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to add tags for saved searches #268

Merged
merged 3 commits into from
Jan 22, 2024
Merged

feat: Allow to add tags for saved searches #268

merged 3 commits into from
Jan 22, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Jan 22, 2024

feat: Allow to add tags for saved searches

Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: 1a2c1ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-shorpo svc-shorpo changed the title sr/tags search feat: Allow to add tags for saved searches Jan 22, 2024
@svc-shorpo svc-shorpo marked this pull request as ready for review January 22, 2024 05:40
@@ -747,6 +780,22 @@ export default function SearchPage() {
setShowSaveSearchModal(true);
}}
/>
<Tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to add a check to ensure the user is actually looking at a saved search, and hide otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops fixed

@kodiakhq kodiakhq bot merged commit 306e42c into main Jan 22, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the sr/tags-search branch January 22, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants