Unify chart page to use edit chart form in dashboard #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MikeShi42
commented
Jan 31, 2024
MikeShi42
commented
🦋 Changeset detectedLatest commit: c65a694 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
reviewed
Jan 31, 2024
| @@ -172,7 +176,7 @@ export function seriesToSearchQuery({ | |||
| aggFn !== 'count' && field ? ` ${field}:*` : '' | |||
| }${ | |||
| 'groupBy' in s && s.groupBy != null && s.groupBy.length > 0 | |||
| ? ` ${s.groupBy}:${groupByValue}` | |||
| ? ` ${s.groupBy}:${groupByValue ?? '*'}` | |||
There was a problem hiding this comment.
This fixes a bug where if the groupByValue is undefined (any group), we use the group:* operator correctly, previously we'd incorrectly search for group:undefined
wrn14897
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.