feat: alert message template - pt1 #318
Conversation
|
| @@ -54,53 +53,6 @@ const validateGroupBy = async ( | |||
| next(); | |||
| }; | |||
|
|
|||
| const translateExternalAlertToInternalAlert = ( | |||
There was a problem hiding this comment.
Move these two methods to zod.ts
| @@ -93,7 +93,7 @@ | |||
| "scripts": { | |||
| "start": "node ./build/index.js", | |||
| "dev": "nodemon --signal SIGTERM -e ts,json --exec 'ts-node' --transpile-only -r tsconfig-paths/register -r '@hyperdx/node-opentelemetry/build/src/tracing' ./src/index.ts", | |||
| "dev:task": "ts-node -r tsconfig-paths/register -r '@hyperdx/node-opentelemetry/build/src/tracing' ./src/tasks/index.ts", | |||
| "dev:task": "ts-node -r tsconfig-paths/register ./src/tasks/index.ts", | |||
There was a problem hiding this comment.
disable tracing for the scheduled task
| blocks: [ | ||
| { | ||
| text: { | ||
| text: [ | ||
| `*<http://localhost:9090/dashboards/${dashboard._id}?from=1700170200000&granularity=5+minute&to=1700174700000 | Alert for "Max Duration" in "My Dashboard">*`, | ||
| 'Group: "HyperDX"', | ||
| '102 exceeds 10', | ||
| '', |
There was a problem hiding this comment.
nit: should we just trim() the rendered string so we don't send extra new lines?
There was a problem hiding this comment.
good idea. let me do it in the next pr
No description provided.