Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI tweaks for session details panel #330

Merged
merged 2 commits into from
Mar 3, 2024
Merged

fix: UI tweaks for session details panel #330

merged 2 commits into from
Mar 3, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Mar 2, 2024

make client session panel look more like a side panel. previously, with certain window width (~14" macbook) it looks like the side bar is not scrollable


Ellipsis 馃殌 This PR description was created by Ellipsis for commit 7a30fd3.

Summary:

This PR improves the UI and usability of the session details panel by adjusting the Drawer properties, adding a d-flex class, and introducing a close button.

Key points:

  • Modified overlayOpacity and size properties of Drawer in SessionSidePanel component.
  • Added d-flex class to a div element.
  • Added a new Button component for closing the panel.

Generated with 鉂わ笍 by ellipsis.dev

Copy link

changeset-bot bot commented Mar 2, 2024

鈿狅笍 No Changeset found

Latest commit: 1aa7481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 Looks good to me!

  • Reviewed the entire pull request up to 7a30fd3
  • Looked at 47 lines of code in 1 files
  • Took 39 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. /packages/app/src/SessionSidePanel.tsx:118:
  • Assessed confidence : 80%
  • Grade: 0%
  • Comment:
    Consider adding some margin or padding to the close button to ensure it's adequately separated from the 'Share Session' button. This can improve user experience by preventing accidental clicks. You can do this by adding a class like 'mx-2' to the className prop of the Button component.
  • Reasoning:
    The changes in this PR seem to be mostly UI tweaks, changing the overlay opacity, size of the drawer, and adding a close button. I don't see any logical bugs or security issues. However, I noticed that the close button doesn't have any margin or padding to separate it from the 'Share Session' button. This could potentially lead to a poor user experience as the buttons could be too close together, making it easy for users to accidentally click the wrong button.

Workflow ID: wflow_o5B5SDuYhC8jCMGn


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@kodiakhq kodiakhq bot merged commit 0e2641e into main Mar 3, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the sr/hdx-249 branch March 3, 2024 23:55
colehpage pushed a commit to colehpage/hyperdx that referenced this pull request Mar 7, 2024
make client session panel look more like a side panel. previously, with certain window width (~14" macbook) it looks like the side bar is not scrollable




----

| <a href="https://ellipsis.dev" target="_blank"><img src="https://avatars.githubusercontent.com/u/80834858?s=400&u=31e596315b0d8f7465b3ee670f25cea677299c96&v=4" alt="Ellipsis" width="30px" height="30px"/></a> | 馃殌 This PR description was created by [Ellipsis](https://www.ellipsis.dev) for commit 7a30fd3.  | 
|--------|--------|

### Summary:
This PR improves the UI and usability of the session details panel by adjusting the `Drawer` properties, adding a `d-flex` class, and introducing a close button.

**Key points**:
- Modified `overlayOpacity` and `size` properties of `Drawer` in `SessionSidePanel` component.
- Added `d-flex` class to a `div` element.
- Added a new `Button` component for closing the panel.


----
Generated with 鉂わ笍 by [ellipsis.dev](https://www.ellipsis.dev)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants