feat: Allow to interact with page while log side panel is open #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5d5a9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 0119837
- Looked at
84lines of code in3files - Took 41 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. packages/app/src/SearchPage.tsx:321:
- Assessed confidence :
50% - Comment:
The condition for setting the opened log has been updated to also check if the opened log id is the same as the log id being set. Please ensure this change doesn't introduce any unexpected behavior in the application. - Reasoning:
The changes in the SearchPage.tsx file are related to the handling of the opened log. The condition for setting the opened log has been updated to also check if the opened log id is the same as the log id being set. This seems to be a logical change to prevent unnecessary updates. However, without knowing the exact behavior of the setOpenedLogQuery function and how it affects the application, it's hard to say if this change could introduce any bugs. I would need to explore the codebase further to understand this.
Workflow ID: wflow_6Nb0oeMko31Jeoen
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
MikeShi42
approved these changes
Mar 3, 2024
colehpage
pushed a commit
to colehpage/hyperdx
that referenced
this pull request
Mar 7, 2024
…dxio#332) Allow to interact with page while log side panel is open https://github.com/hyperdxio/hyperdx/assets/149748269/0c7baa7e-9ffb-4bd4-994f-764dc73eca84 ---- | <a href="https://ellipsis.dev" target="_blank"><img src="https://avatars.githubusercontent.com/u/80834858?s=400&u=31e596315b0d8f7465b3ee670f25cea677299c96&v=4" alt="Ellipsis" width="30px" height="30px"/></a> | 🚀 This PR description was created by [Ellipsis](https://www.ellipsis.dev) for commit 0119837. | |--------|--------| ### Summary: This PR enhances user interaction by allowing page interaction while the log side panel is open, achieved by using the `useClickOutside` hook in `LogSidePanel.tsx` and updating the `setOpenedLog` function in `SearchPage.tsx`. **Key points**: - Added `useClickOutside` hook from `@mantine/hooks` in `LogSidePanel.tsx` to create a `drawerRef`. - Used `drawerRef` to close the drawer when a click is detected outside of it. - Updated `enableOverlay` prop of `Drawer` component to depend on `subDrawerOpen` state. - Added condition in `setOpenedLog` function in `SearchPage.tsx` to prevent unnecessary updates when the log is already open. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to interact with page while log side panel is open
Screen.Recording.2024-03-03.at.9.44.16.PM.mov
Summary:
This PR enhances user interaction by allowing page interaction while the log side panel is open, achieved by using the
useClickOutsidehook inLogSidePanel.tsxand updating thesetOpenedLogfunction inSearchPage.tsx.Key points:
useClickOutsidehook from@mantine/hooksinLogSidePanel.tsxto create adrawerRef.drawerRefto close the drawer when a click is detected outside of it.enableOverlayprop ofDrawercomponent to depend onsubDrawerOpenstate.setOpenedLogfunction inSearchPage.tsxto prevent unnecessary updates when the log is already open.Generated with ❤️ by ellipsis.dev