Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support HYPERDX_LOG_LEVEL env var #66

Merged
merged 10 commits into from Oct 18, 2023
Merged

Conversation

wrn14897
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 563ac75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MikeShi42
MikeShi42 previously approved these changes Oct 18, 2023
@@ -185,6 +185,15 @@ comprehensive documentation on how we balance between cloud-only and open source
features in the future. In the meantime, we're highly aligned with Gitlab's
[stewardship model](https://handbook.gitlab.com/handbook/company/stewardship/).

## Frequently Asked Questions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just throwing this out there - we should probably have a separate deployment guide to wrap up some of the new stuff around custom URLs, log levels, etc. that we get from users that need to customize their deployment beyond a local stack. And help keep the readme lean to mainly for quick start + project overview.

Not something we need to do this minute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Yeah we should put all custom deployment things together

README.md Outdated
#### How to suppress all logs from HyperDX itself ?

To suppress logs of a service, you can comment out the `HYPERDX_API_KEY`
environment variable in the docker-compose.yml file. Logs mainly come from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs mainly come from app, api and miner services.

I'm not sure if this blanket statement is true, I think otel collector and vector are even more spammy and probably the thing I'd want to tune with log level the most. I think we can just omit this line for now since users can likely find which log source they're interested in muting anyways if they find it spammy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the logs here are those you can see within HyperDX. Let me update it

@kodiakhq kodiakhq bot merged commit 389bb3a into main Oct 18, 2023
3 checks passed
@kodiakhq kodiakhq bot deleted the warren/set-hdx-logs-max-level branch October 18, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants