Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDX-45] Suppress Services' Logs #54

Closed
wrn14897 opened this issue Oct 2, 2023 · 5 comments
Closed

[HDX-45] Suppress Services' Logs #54

wrn14897 opened this issue Oct 2, 2023 · 5 comments
Assignees
Labels
linear Created by Linear-GitHub Sync

Comments

@wrn14897
Copy link
Contributor

wrn14897 commented Oct 2, 2023

Users should be able to suppress HyperDX services' logs by setting env vars like 'HDX_LOG_LEVEL'

@wrn14897 wrn14897 added linear Created by Linear-GitHub Sync and removed linear Created by Linear-GitHub Sync labels Oct 2, 2023
@wrn14897 wrn14897 self-assigned this Oct 15, 2023
@Seikilos
Copy link

Seikilos commented Oct 17, 2023

FYI:
Tried to use hyperdx at work behind a fairly crazy amount of proxy and whitelisting-only IT sec and failed.

Docker registry is fine, but when it comes to make build-local because I have to change the .env file, there is currently no way to do it for us because many urls are blocked. If changing log level will also mean changing .env file, then we are out of luck :/

@wrn14897
Copy link
Contributor Author

wrn14897 commented Oct 17, 2023

FYI: Tried to use hyperdx at work behind a fairly crazy amount of proxy and whitelisting-only IT sec and failed.

Docker registry is fine, but when it comes to make build-local because I have to change the .env file, there is currently no way to do it for us because many urls are blocked. If changing log level will also mean changing .env file, then we are out of luck :/

make build-local is mainly for rebuilding the frontend app. In this case, you can just pull the code and restart the docker containers and log level should be applied (we will publish new images if code update is required). For frontend (or any services) logs/traces, you can remove HYPERDX_API_KEY env var if you don't want those to be recorded

@Seikilos
Copy link

FYI: Tried to use hyperdx at work behind a fairly crazy amount of proxy and whitelisting-only IT sec and failed.
Docker registry is fine, but when it comes to make build-local because I have to change the .env file, there is currently no way to do it for us because many urls are blocked. If changing log level will also mean changing .env file, then we are out of luck :/

make build-local is mainly for rebuilding the frontend app. In this case, you can just pull the code and restart the docker containers and log level should be applied (we will publish new images if code update is required). For frontend (or any services) logs/traces, you can remove HYPERDX_API_KEY env var if you don't want those to be recorded

But isn't rebuilding required, when I at least change localhost to an internal server IP (this is unrelated to log verbosity though)?

@wrn14897
Copy link
Contributor Author

wrn14897 commented Oct 17, 2023

FYI: Tried to use hyperdx at work behind a fairly crazy amount of proxy and whitelisting-only IT sec and failed.
Docker registry is fine, but when it comes to make build-local because I have to change the .env file, there is currently no way to do it for us because many urls are blocked. If changing log level will also mean changing .env file, then we are out of luck :/

make build-local is mainly for rebuilding the frontend app. In this case, you can just pull the code and restart the docker containers and log level should be applied (we will publish new images if code update is required). For frontend (or any services) logs/traces, you can remove HYPERDX_API_KEY env var if you don't want those to be recorded

But isn't rebuilding required, when I at least change localhost to an internal server IP (this is unrelated to log verbosity though)?

You can lock your 'app' service image version (in compose file) and you don't need to rebuild images since other services should be able to read URL env var dynamically. For frontend session recording specifically, the api key is sent from the next server so it should be okay to remove HYPERDX_API_KEY without rebuilding as well

@wrn14897
Copy link
Contributor Author

The issue should be fixed (#66). Check out readme for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants