-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Toggle columns from LogSidePanel #82
Conversation
🦋 Changeset detectedLatest commit: f9c657d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
style={{ width: 20 }} | ||
onClick={() => toggleColumn(keyPathString)} | ||
> | ||
<i className="bi bi-table" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know if I should use a different icon :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 lgtm!
packages/app/src/LogSidePanel.tsx
Outdated
displayedColumns?.includes(keyPathString) | ||
? 'Remove' | ||
: 'Add' | ||
} ${keyPathString} column`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} ${keyPathString} column`} | |
} ${keyPathString} column from results table`} |
Nit: Would make it a tiny bit more clear what the button does, though the table icon should help!
Allow to toggle columns from LogSidePanel