Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar display for line chart, add chart error msg #89

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

MikeShi42
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 02b2794

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -345,10 +361,18 @@ const HDXLineChart = memo(
});
}

const [displayType, setDisplayType] = useState<'stacked_bar' | 'line'>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will leave persisting this into the chart obj for later

Copy link
Contributor

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeShi42 MikeShi42 self-assigned this Nov 17, 2023
@kodiakhq kodiakhq bot merged commit c56fe9c into main Nov 17, 2023
3 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/chart-ui-improvements branch November 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants