-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session replay improvements #9
Conversation
MikeShi42
commented
Sep 19, 2023
- Add explicit email filter
- Add empty replay message info
- Filter out empty replay sessions from the replay page as it's usually confusing (we may want to revisit using the replay table instead of the event stream table for filtering though - open to comments)
![image](https://private-user-images.githubusercontent.com/2781687/268916548-a6a07089-8a29-4cfb-81e0-9d40aef393da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxOTUyMDEsIm5iZiI6MTcyNDE5NDkwMSwicGF0aCI6Ii8yNzgxNjg3LzI2ODkxNjU0OC1hNmEwNzA4OS04YTI5LTRjZmItODFlMC05ZDQwYWVmMzkzZGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMjMwMTQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjU4NzcyMGYxODQ0MjRlZGVlZjA1ZDY0NmE1YmQwNmNhZDZhZDYwMGIzNTRhNzE0ZmY0ODhhNDZmMWZmODlmZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.SuykEfFjXQa5C2-lxHcmbA8dPqq6rIF-8fIItLiSlJs)
…ty replay search filter
🦋 Changeset detectedLatest commit: 3b4715f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1090,9 +1089,36 @@ export const getSessions = async ({ | |||
], | |||
); | |||
|
|||
const sessionsWithRecordingsQuery = SqlString.format( | |||
`WITH sessions AS (${sessionsWithSearchQuery}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be nice to merge queries for readablility (also make query parameterization migration a bit easier). but no big deal, I can clean it up later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case this query execution is conditional (as this is a slower path), unless you were thinking of having the original query CTE duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I was thinking to have CTE inline basically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'ma merge this as-is right now, and we can probably revisit that later - likely we'll need to tune this due to perf anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm