Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error checking for PostgreSQLStatement::execute method. #5121

Merged
merged 8 commits into from
Oct 11, 2022
Merged

Add error checking for PostgreSQLStatement::execute method. #5121

merged 8 commits into from
Oct 11, 2022

Conversation

her-cat
Copy link
Contributor

@her-cat her-cat commented Oct 6, 2022

Fixed: #5120

@huangzhhui
Copy link
Member

补个单测？

@her-cat
Copy link
Contributor Author

her-cat commented Oct 8, 2022

@huangzhhui @limingxinleo 已经添加了单测，麻烦看一下。

limingxinleo
limingxinleo previously approved these changes Oct 11, 2022
View reviewed changes
@limingxinleo limingxinleo merged commit 677c9da into hyperf:master Oct 11, 2022
@her-cat her-cat deleted the pgsql/fix-execute-result branch October 11, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limingxinleo limingxinleo limingxinleo approved these changes

@volodymyr-hordiienko volodymyr-hordiienko volodymyr-hordiienko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Pgsql-swoole bad insert error when sql not valid
4 participants
@her-cat @huangzhhui @volodymyr-hordiienko @limingxinleo