Update tracing-subscriber and use tracing-tree when testing #586
Conversation
|
This removes timestamps, but durations are still shown, so I don't know if this is good enough or not. |
There was a problem hiding this comment.
overall, this seems like a good idea, and i'm onboard with switching to the tracing-tree crate for test logging. i had a few suggestions --- in particular, i think we probably want the log output to be captured by libtest.
once that's addressed, i think this will be good to merge.
| .with_indent_lines(true) | ||
| .with_ansi(use_colors) | ||
| .with_targets(true) | ||
| .with_indent_amount(2); |
There was a problem hiding this comment.
take it or leave it: perhaps we want to add
| .with_indent_amount(2); | |
| .with_indent_amount(2) | |
| .with_thread_ids(true) | |
| .with_thread_names(true); |
in particular, adding thread names will give us a nice way to know which test the events were logged from, since the thread's name defaults to the name of the test.
There was a problem hiding this comment.
I added it but I'm not sure this is useful: I only ever look at logs running a single test, not many of them.
There was a problem hiding this comment.
It's a bit verbose as you can see.
There was a problem hiding this comment.
hmm, we could remove it --- i suppose that since libtest is capturing the logs now, they'll also be printed out per-test. the only reason to consider having thread names here is if we have tests that spawn multiple threads and they give names to those threads...and we only have one test that spawns threads (https://github.com/hyperium/h2/search?q=thread%3A%3Aspawn).
i'm fine with removing the thread-name configuration, then!
This makes reading the logs way easier on the eyes.
This makes reading the logs way easier on the eyes.