Skip to content

Commit

Permalink
Update tracing-subscriber and use tracing-tree when testing (#586)
Browse files Browse the repository at this point in the history
This makes reading the logs way easier on the eyes.
  • Loading branch information
nox authored Jan 21, 2022
1 parent d92ba1c commit a28a39c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 36 deletions.
4 changes: 3 additions & 1 deletion tests/h2-support/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ edition = "2018"
[dependencies]
h2 = { path = "../..", features = ["stream", "unstable"] }

atty = "0.2"
bytes = "1"
tracing = "0.1"
tracing-subscriber = { version = "0.2", default-features = false, features = ["fmt", "chrono", "ansi"] }
tracing-subscriber = { version = "0.3", default-features = false, features = ["fmt"] }
tracing-tree = "0.2"
futures = { version = "0.3", default-features = false }
http = "0.2"
tokio = { version = "1", features = ["time"] }
Expand Down
46 changes: 11 additions & 35 deletions tests/h2-support/src/trace.rs
Original file line number Diff line number Diff line change
@@ -1,41 +1,17 @@
use std::{io, str};
pub use tracing;
pub use tracing_subscriber;

pub fn init() -> tracing::dispatcher::DefaultGuard {
tracing::subscriber::set_default(
tracing_subscriber::fmt()
.with_max_level(tracing::Level::TRACE)
.with_span_events(tracing_subscriber::fmt::format::FmtSpan::CLOSE)
.with_writer(PrintlnWriter { _p: () })
.finish(),
)
}

struct PrintlnWriter {
_p: (),
}
use tracing_subscriber::layer::SubscriberExt;
use tracing_subscriber::util::SubscriberInitExt;

impl tracing_subscriber::fmt::MakeWriter for PrintlnWriter {
type Writer = PrintlnWriter;
fn make_writer(&self) -> Self::Writer {
PrintlnWriter { _p: () }
}
}

impl io::Write for PrintlnWriter {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
let s = str::from_utf8(buf).map_err(|e| io::Error::new(io::ErrorKind::InvalidInput, e))?;
println!("{}", s);
Ok(s.len())
}

fn write_fmt(&mut self, fmt: std::fmt::Arguments<'_>) -> io::Result<()> {
println!("{}", fmt);
Ok(())
}
pub fn init() -> tracing::dispatcher::DefaultGuard {
let use_colors = atty::is(atty::Stream::Stdout);
let layer = tracing_tree::HierarchicalLayer::default()
.with_writer(tracing_subscriber::fmt::writer::TestWriter::default())
.with_indent_lines(true)
.with_ansi(use_colors)
.with_targets(true)
.with_indent_amount(2);

fn flush(&mut self) -> io::Result<()> {
Ok(())
}
tracing_subscriber::registry().with(layer).set_default()
}

0 comments on commit a28a39c

Please sign in to comment.