Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all protocols supported by upstream hyper via ALPN by default #61

Closed
nagisa opened this issue Feb 5, 2020 · 3 comments
Closed

Comments

@nagisa
Copy link

nagisa commented Feb 5, 2020

Disclaimer: I didn’t look at the code from this crate for too long.

This crate appears to be pretty much the most hands free way to get https support with hyper. However, a caveat is that this does not do any protocol negotiation and thus hyper is forced to always use http1.1.

I think it should, by default, do most of this kind of setup for the user without any additional effort on the user end.

@CryZe
Copy link

CryZe commented Feb 5, 2020

Isn't the problem that native-tls doesn't support ALPN? (Because it's only implemented on a few of the underlying native implementations).

@seanmonstar
Copy link
Member

Correct, native-tls doesn't have ALPN support, and won't until all the backends have support added (see sfackler/rust-native-tls#113).

nightkr added a commit to nightkr/hyper-tls that referenced this issue Dec 26, 2020
@RAnders00
Copy link

Do we want to reopen this given that native-tls added ALPN support now? https://github.com/sfackler/rust-native-tls/blob/master/CHANGELOG.md#v027 The documentation around the new feature seems to be rather lackluster though, the alpn flag is only mentioned in the changelog and not on the docs.rs or in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants