Update to tokio version 1.0 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tesaguri
reviewed
Jan 6, 2021
|
Also, something that I forgot to mention, the rt and macros features of tokio were moved to dev-dependencies, they just weren't needed. |
|
@QuietMisdreavus could you please give this a review too? |
bombsimon
added a commit
to bombsimon/tweets-to-discord
that referenced
this pull request
Jan 21, 2021
This requires a custom fork/branch of egg-mode until egg-mode-rs/egg-mode#111 is merged. This PR just confirms that the code is running with tokio 1.0.2 but will probably not merge to main until egg-mode is updated. Closes #5.
|
any updates on this? I am currently using [replace]
"egg-mode:0.15.0" = { git = "https://github.com/RAnders00/egg-mode", branch = "tokio-v1.0-upgrade", rev = "11dc221533288ebcb1b135c2df65f187a80cd255", features = ["rustls"], default-features = false }as a hoffix and it works, but dropping this would be great! |
|
Thanks! Maybe @adwhit has time to look at this? I saw them in the commit history for the most recent git commit. |
|
Sure, I can take a look at this. It's obviously something we want |
|
LGTM, thanks! |
Closed
bombsimon
added a commit
to bombsimon/tweets-to-discord
that referenced
this pull request
Jul 11, 2021
This requires a custom fork/branch of egg-mode until egg-mode-rs/egg-mode#111 is merged. This PR just confirms that the code is running with tokio 1.0.2 but will probably not merge to main until egg-mode is updated. Closes #5.
bombsimon
added a commit
to bombsimon/tweets-to-discord
that referenced
this pull request
Jul 11, 2021
This requires a custom fork/branch of egg-mode until egg-mode-rs/egg-mode#111 is merged. This PR just confirms that the code is running with tokio 1.0.2 but will probably not merge to main until egg-mode is updated. Closes #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My pull request generally bumps all outdated dependencies, but most importantly it updates to tokio v1.0.