feat(CI): check external types #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
force-pushed
the
check-external-types
branch
3 times, most recently
from
b896d8d
to
5ef1664
Compare
This comment was marked as outdated.
This comment was marked as outdated.
palango
force-pushed
the
check-external-types
branch
from
5ef1664
to
e058d23
Compare
palango
force-pushed
the
check-external-types
branch
from
e058d23
to
385bbd8
Compare
seanmonstar
reviewed
Sep 18, 2023
seanmonstar
reviewed
Sep 18, 2023
This adds CI job that runs `cargo-check-external-types` against a whitelist of exported types.
palango
force-pushed
the
check-external-types
branch
from
20a097a
to
511e0b3
Compare
seanmonstar
approved these changes
Sep 19, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
This adds CI job that runs `cargo-check-external-types` against a whitelist of exported types. Closes hyperium#2925
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
This adds CI job that runs `cargo-check-external-types` against a whitelist of exported types. Closes hyperium#2925 Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CI job that runs
cargo-check-external-typesagainst a whitelist of exported types.Whitelist in #2925 (comment) didn't change.
For now the nightly for this needs to be pinned to
nightly-2022-11-16, becausecargo-check-external-typesdoesn't work with the latest nightly json doc format.Resolves #2925
Superseeds #2957