Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): check external types #3152

Merged
merged 1 commit into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- ffi
- ffi-header
- doc
- check-external-types
steps:
- run: exit 0

Expand Down Expand Up @@ -210,3 +211,26 @@ jobs:

- name: cargo doc
run: cargo rustdoc --features full,ffi -- --cfg docsrs --cfg hyper_unstable_ffi -D broken-intra-doc-links

check-external-types:
palango marked this conversation as resolved.
Show resolved Hide resolved
name: Check exposed types
needs: [style, test]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Install Rust
uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2023-05-31 # Compatible version for cargo-check-external-types

- name: Install cargo-check-external-types
uses: actions-rs/install@v0.1
with:
crate: cargo-check-external-types
version: 0.1.7
use-tool-cache: true

- name: check-external-types
run: cargo check-external-types --config .github/workflows/external-types.toml
15 changes: 15 additions & 0 deletions .github/workflows/external-types.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
allowed_external_types = [
"bytes::buf::buf_impl::Buf",
"bytes::bytes::Bytes",
"http::header",
"http::header::map::HeaderMap",
"http::method::Method",
"http::request::Request",
"http::response::Response",
"http::status::StatusCode",
"http::uri::Uri",
"http::version::Version",
"http_body::Body",
"http_body::frame::Frame",
"http_body::size_hint::SizeHint",
]