feat(tls): Add ability to add multiple ca certificates #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
multiple-ca-certificates
branch
4 times, most recently
from
bd66035
to
c3f9ae5
Compare
djc
approved these changes
Jun 13, 2024
|
I would think that |
|
Well, the caller would rely on rustls-pemfile so it's one less mandatory dependency to carry within tonic. |
|
Considering |
|
Added a method to add multiple ca certificates at once, which is useful when having some sets of certificates. |
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
8781f15
to
9e76a66
Compare
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
9e76a66
to
0837c0b
Compare
djc
approved these changes
Jun 15, 2024
tonic/src/transport/channel/tls.rs
Outdated
| @@ -51,6 +51,13 @@ impl ClientTlsConfig { | |||
| ClientTlsConfig { certs, ..self } | |||
| } | |||
|
|
|||
| /// Sets the multiple CA Certificates against which to verify the server's TLS certificate. | |||
| pub fn ca_certificates(self, ca_certificates: Vec<Certificate>) -> Self { | |||
There was a problem hiding this comment.
Let's take an impl IntoIterator<Item = Certificate> here, instead?
There was a problem hiding this comment.
Sounds good to me. Updated to use it.
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
0837c0b
to
2c3ebee
Compare
djc
approved these changes
Jun 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1629.